🛠️ Fix CI#4076
Merged
qgallouedec merged 4 commits intomainfrom Sep 13, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
commented
Sep 13, 2025
Comment on lines
-264
to
-275
| config = config_class( | ||
| vocab_size=len(tokenizer.vocab), | ||
| d_model=16, | ||
| encoder_layers=2, | ||
| decoder_layers=2, | ||
| d_kv=2, | ||
| d_ff=64, | ||
| num_layers=6, | ||
| num_heads=8, | ||
| decoder_start_token_id=0, | ||
| is_encoder_decoder=True, | ||
| ) |
Member
Author
There was a problem hiding this comment.
the issue came from this config that was not correct. It's way easier to just modify the config from an existing model
qgallouedec
requested review from
albertvillanova,
edbeeching,
kashif and
lewtun
kashif
approved these changes
Sep 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR huggingface/transformers#40416 introduced a new key in the log history, which makes the CI (dev deps) to fail. We just need to check that all the keys/values are included in the log history, no need to check this new key
huggingface/transformers#40772 changed how cache is handled for encoder-decoder