Account for additional processor outputs#4191
Closed
KarelKenens wants to merge 4 commits intohuggingface:mainfrom
Closed
Account for additional processor outputs#4191KarelKenens wants to merge 4 commits intohuggingface:mainfrom
KarelKenens wants to merge 4 commits intohuggingface:mainfrom
Conversation
5 tasks
Member
|
closing in favour of #4190, thanks @KarelKenens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In
DataCollatorForVisionLanguageModeling, attempt to dynamically determine additional processor outputs, on top ofinput_idsandattention_mask. For example in the Gemma 3 model family alsotoken_type_idsare part of the output (and required futher downstream).Fixes #4189
@qgallouedec , similar to #4190