Enable vLLM sleep mode for generation in Online DPO#4882
Merged
qgallouedec merged 5 commits intohuggingface:mainfrom Jan 21, 2026
Merged
Enable vLLM sleep mode for generation in Online DPO#4882qgallouedec merged 5 commits intohuggingface:mainfrom
qgallouedec merged 5 commits intohuggingface:mainfrom
Conversation
lewtun
approved these changes
Jan 21, 2026
trl/trainer/online_dpo_trainer.py
Outdated
|
|
||
| self.llm = LLM(**vllm_kwargs) | ||
| if self.args.vllm_enable_sleep_mode: | ||
| self.llm.sleep(level=1) |
Member
There was a problem hiding this comment.
Any reason to choose level 1 vs level 2 (the latter also discards the model weights which is why we do it for GRPOTrainer): https://docs.vllm.ai/en/latest/features/sleep_mode/#sleep-levels
Member
There was a problem hiding this comment.
fair, we switched to mode 2 in #4296 for GRPO and RLOO. Let's do the same here
trl/trainer/online_dpo_trainer.py
Outdated
| prompt_ids = [list(output.prompt_token_ids) for _ in range(2) for output in outputs] | ||
|
|
||
| if self.args.vllm_enable_sleep_mode: | ||
| self.llm.sleep(level=1) |
Member
There was a problem hiding this comment.
Same comment here about level 1 vs level 2
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
qgallouedec
changed the title
qgallouedec
approved these changes
Jan 21, 2026
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.