feature: Configurable num logprobs in vLLM generation#5107
Open
LeonEricsson wants to merge 5 commits intohuggingface:mainfrom
Open
feature: Configurable num logprobs in vLLM generation#5107LeonEricsson wants to merge 5 commits intohuggingface:mainfrom
LeonEricsson wants to merge 5 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logprobsparameter across the vLLM generation stack (client, server, and generation orchestrator), allowing callers to request the top-N log-probabilities per generated token rather than only the sampled token's log-probability.VLLMGeneration::generatereturns a newlogprob_token_idsfield alongsidelogprobs, both with shape(num_sequences, seq_len, num_logprobs), giving downstream consumers access to the full top-k distribution.Motivation
This change is a prerequisite for an upcoming PR I’m working on.
More broadly, it is a strict improvement over the original implementation. Previously,
logprobswas hardcoded to0, which discarded the richer top-k information that vLLM already computes internally. I was lazy when I implemented this the first time around because we only needed sampled logps. By exposing thelogprobsparameter, we incur no additional overhead while unlocking access to information that was previously inaccessible.Minimal upstream effect,
GRPOTrainerandRLOOTraineruse the defaultlogprobs=0todo
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.