Refactor CLI [7/N]: Move patching to compat and import transformers conditionally#5208
Merged
albertvillanova merged 3 commits intohuggingface:mainfrom Mar 3, 2026
Merged
Conversation
qgallouedec
approved these changes
Mar 3, 2026
catherinelee274
pushed a commit
to catherinelee274/trl
that referenced
this pull request
Apr 17, 2026
songhappy
pushed a commit
to songhappy/trl
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move patching to
_compatand import transformers conditionally:Note that currently, importing
transformersunconditionally, increases latency even if the patch is not necessary. See upstream issue:This PR refactors the way compatibility with older versions of the
transformersandacceleratelibraries is handled, specifically regarding theParallelismConfigsymbol. The patch moves the compatibility workaround forParallelismConfigfromtrl/scripts/utils.pyto a more appropriate location intrl/_compat.py, and improves its implementation by adding version checks and error handling.Transformers/Accelerate Compatibility Improvements:
_patch_transformers_parallelism_configintrl/_compat.pyto ensuretransformers.training_args.ParallelismConfigis defined only when bothtransformers<4.57.0andaccelerate<1.10.1are installed, preventingNameErrorduring type hint resolution. The function includes error handling and a detailed docstring explaining its purpose and upstream context._ensure_transformers_parallelism_configfromtrl/scripts/utils.py, as this logic is now handled (with improvements) intrl/_compat.py.