Mark test_rloo[fsdp2] as xfail for transformers 5.4.0#5387
Merged
qgallouedec merged 1 commit intohuggingface:mainfrom Mar 27, 2026
Merged
Mark test_rloo[fsdp2] as xfail for transformers 5.4.0#5387qgallouedec merged 1 commit intohuggingface:mainfrom
qgallouedec merged 1 commit intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
approved these changes
Mar 27, 2026
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI failure for distributed test_rloo[fsdp2]:
Fix #5386.
See upstream fix:
This PR marks the "fsdp2" configuration of the distributed test suite as an expected failure (xfail) for a specific version of the
transformerslibrary, providing clearer test outcomes and documentation for known upstream issues.Testing improvements:
pytest.paramfor the "fsdp2" configuration intest_rloo, marking it as an expected failure (xfail) whentransformersversion is exactly 5.4.0, with a detailed reason and strict enforcement. This documents and accounts for an upstream issue causing NaN weights on non-rank-0 FSDP processes.Note
Low Risk
Low risk: test-only change that marks a known upstream
transformers==5.4.0FSDP issue as an expected failure, without affecting runtime code paths.Overview
Marks the distributed
test_rloocase for thefsdp2configuration asxfailspecifically ontransformers==5.4.0, with a documented reason andstrict=Trueto prevent silent passes.This stabilizes CI by treating the known upstream NaN-weight failure on non-rank-0 FSDP processes as an expected, version-gated test outcome.
Written by Cursor Bugbot for commit a502f50. This will update automatically on new commits. Configure here.