Revert hotfix CI for TypeError: 'NoneType' object is not iterable#5438
Merged
albertvillanova merged 2 commits intohuggingface:mainfrom Apr 2, 2026
Merged
Conversation
…ypeError: 'NoneType' object is not iterable" This reverts commit d3a7fca.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
approved these changes
Apr 2, 2026
Member
qgallouedec
left a comment
There was a problem hiding this comment.
LGTM if this CI does pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert hotfix CI for TypeError: 'NoneType' object is not iterable
This reverts commit d3a7fca:
Note that my upstream fix in
transformersis already merged:This PR removes an
xfailmarker for the"trl-internal-testing/tiny-LlavaNextForConditionalGeneration"model in two test files. This means the related tests will no longer be expected to fail due to the previously referenced upstream issue.Changes
Test suite updates:
pytest.mark.xfailmarker for"trl-internal-testing/tiny-LlavaNextForConditionalGeneration"intest_prepare_input_called_with_correct_datain bothtests/test_grpo_trainer.pyandtests/test_rloo_trainer.py, so these tests will now run as normal.Note
Low Risk
Only adjusts pytest expectations by removing an
xfailguard, so risk is limited to potentially reintroducing CI failures if the upstreamtransformersregression resurfaces.Overview
Removes the conditional
pytest.mark.xfailaround thetrl-internal-testing/tiny-LlavaNextForConditionalGenerationVLM case in bothtests/test_grpo_trainer.pyandtests/test_rloo_trainer.py, so these parametrized vision-language trainer tests now run and are expected to pass on devtransformersversions as well.Written by Cursor Bugbot for commit 8b1f6c4. This will update automatically on new commits. Configure here.