Skip to content

Revert hotfix CI for TypeError: 'NoneType' object is not iterable#5438

Merged
albertvillanova merged 2 commits intohuggingface:mainfrom
albertvillanova:revert-5427-hotfix-5425
Apr 2, 2026
Merged

Revert hotfix CI for TypeError: 'NoneType' object is not iterable#5438
albertvillanova merged 2 commits intohuggingface:mainfrom
albertvillanova:revert-5427-hotfix-5425

Conversation

@albertvillanova
Copy link
Copy Markdown
Member

@albertvillanova albertvillanova commented Apr 2, 2026

Revert hotfix CI for TypeError: 'NoneType' object is not iterable

This reverts commit d3a7fca:

Note that my upstream fix in transformers is already merged:

This PR removes an xfail marker for the "trl-internal-testing/tiny-LlavaNextForConditionalGeneration" model in two test files. This means the related tests will no longer be expected to fail due to the previously referenced upstream issue.

Changes

Test suite updates:

  • Removed the pytest.mark.xfail marker for "trl-internal-testing/tiny-LlavaNextForConditionalGeneration" in test_prepare_input_called_with_correct_data in both tests/test_grpo_trainer.py and tests/test_rloo_trainer.py, so these tests will now run as normal.

Note

Low Risk
Only adjusts pytest expectations by removing an xfail guard, so risk is limited to potentially reintroducing CI failures if the upstream transformers regression resurfaces.

Overview
Removes the conditional pytest.mark.xfail around the trl-internal-testing/tiny-LlavaNextForConditionalGeneration VLM case in both tests/test_grpo_trainer.py and tests/test_rloo_trainer.py, so these parametrized vision-language trainer tests now run and are expected to pass on dev transformers versions as well.

Written by Cursor Bugbot for commit 8b1f6c4. This will update automatically on new commits. Configure here.

…ypeError: 'NoneType' object is not iterable"

This reverts commit d3a7fca.
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if this CI does pass

@albertvillanova albertvillanova merged commit 2929bc0 into huggingface:main Apr 2, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants