fix: specify utf-8 encoding in read_text calls on Windows#31
Open
sachinML wants to merge 1 commit intohuggingface:mainfrom
Open
fix: specify utf-8 encoding in read_text calls on Windows#31sachinML wants to merge 1 commit intohuggingface:mainfrom
sachinML wants to merge 1 commit intohuggingface:mainfrom
Conversation
Author
|
Hi, just following up on this PR. |
Author
|
Hi @burtenshaw, do you see any possible improvements in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Windows encoding issues caused by calling
read_text()without specifyingencoding="utf-8".On Windows,
Path.read_text()can default to cp1252, which may break when reading UTF-8 files. This PR updates the relevant call(s) to use UTF-8 explicitly.Fixes #18