Sorting get reversed after update

[Anydog]

@mattheu - Hi, I'm using your branch - wonderfully adapted ...

However, one issue - sorting is reversing order upon save ... It seems that happens randomly - see here - http://www.screenr.com/fCCH

Any ideas (at least where to look) ?

Thanks

[mattheu]

I'll take a look.

The main reason I have not merged this branch is that I have had some
similar reports, however I have not been able to reproduce.

I think the issue is that WordPress get_post_meta function does not
explicitly order by meta ID - so the plugin fetches the fields they may not
be returned in the correct order.

Could you check what version of PHP & MySQL you are using?

Thanks

On Tue, Jul 23, 2013 at 8:51 PM, Anydog notifications@github.com wrote:

@mattheu https://github.com/mattheu - Hi, I'm using your branch -
wonderfully adapted ...

However, one issue - sorting is reversing order upon save ... It seems
that happens randomly - see here - http://www.screenr.com/fCCH

Any ideas (at least where to look) ?

Thanks

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/76
.

Matthew Haines-Young
Human Made Limited
Email: matthew@humanmade.co.uk
Skype: matthewhainesyoung
Tel: +44 7929 183 298

[Anydog]

@mattheu
Hi, thanks for fast reply ... I'm using Apache 2.4.4, MySQL 5.6.11, PHP 5.5.0 (XAMPP 1.8.3 for Windows). Are the functions handling this in tests/testField.php ?

[Anydog]

@mattheu - sorry for nag - could you please point me to right direction, which files/functions/classes to edit ?

Thanks

[mattheu]

Sorry I've not hot back to you, I'm on holidaybat the moment.

The data is retrieved from the db in the init_fields method of the CmB_Meta_Box class isn't class.cmb-meta-box.php.

Saving data is handled by a save method on the CMB_Fiekd class in classes.fields.php

It uses Built in WP functions for getting and setting meta. If this is not returning data in the correct order it may require storing the order separately.

[Anydog]

@mattheu - oh sorry to bothering you on holliday (or, sorry to bother you at all ... ;) ). Thanks for this info, I'll dig into it and see what can I do.
Thanks again and enjoy the hollidays ... 👍

[jonathanbardo]

If I'm right, WordPress doesn't specify any "ORDER BY" when they query the database for meta (See line 558 in http://core.trac.wordpress.org/browser/tags/3.5.2/wp-includes/meta.php#L558) and MySQL doesn't have any default statement (see : http://dba.stackexchange.com/questions/6051/what-is-the-default-order-of-records-for-a-select-statement-in-mysql). A simple fix would be to change the query of line 558 of meta.php to this : "SELECT $column, meta_key, meta_value FROM $table WHERE $column IN ($id_list) ORDER BY meta_id".

[jonathanbardo]

Of course... never modify core directly !

[Anydog]

Thanks guys for the guidance ... We will see how it goes from here ... As it seems the problem is in saving the meta, when it's displayed it always displays meta in same order (in the front end, with get_post_meta() ) ...
Of course, no core will be touched ... :)

[Anydog]

Unfortunately, haven't found a solution ... This code is a bit over my head ... Guys, it's on you .. ;)

[pdubb-sauce]

Hi, I have encountered the same problem as well, although I don't remember it being an issue when I first started working with repeatable fields around 6 months ago.

I find that every time I update a post that has repeatable fields (& groups), their order is shuffled each time. It happens to a simple text field that is set to repeatable, or a group that contains 2 repeatable text fields.

Are there any plans to refine this part of functionality so that repeatable fields can be reliably ordered each time a post is updated?

p.s. This whole CMB package is awesome, so flexible and thorough, many thanks to all who have developed it.

[banago]

I've experienced the same issue with repeatable fields too.

[mattheu]

Hi, thanks for reporting this. This is an issue I would really like to fix.

I have created a branch that should fix this. It would be great if you could test it for me.

However I'm not sure this is the best solution.

[mattheu]

I have opened a pull request to continue discussion about how best to impleemnt this. #98

[andretp1]

Latest fixed it for me, thanks a lot !