Conversation
Conflicts: css/style.css
Member
|
Nice! |
|
WOW |
Use divs and CSS to style grid layout instead of tables.
Conflicts: classes.fields.php css/legacy.css
Merged
Closed
Member
Author
|
I'm happy with this. Good to get a review/merge (cc @joehoyle ) |
Conflicts: classes.fields.php js/cmb.js
Member
Author
|
Fixed conflicts. |
Member
|
@mattheu coudl we get some screenshots? |
Member
Author
Member
Author
|
@joe - Bump - any chance of a review/merge. 3.8 isn't far off now. |
Member
There was a problem hiding this comment.
We shouldn't need the & me thinks, why did you need that?
Member
Author
There was a problem hiding this comment.
Isn't this needed in order to use the value returned by get_fields() as a reference to $this->fields right? Am I doing it wrong?
I'm going to merge anyway because this was actually added already - I just moved the function in this PR. I would like to ensure I'm doing it the right way.
Member
|
Looks good, couple of small notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

MP6 has landed in trunk.
This is a great opportunity to have a real good spring clean of all the styles.
I am still loading the old styles for WP pre 3.8. This allows us to merge this ASAP and those using trunk and MP6 plugin will get the benefits already. If we need to we can maintain a backwards compatable non MP6 stylesheet going forwards - we can do although it would be a pain.
TODO
Note I have merged #115 into this already. So review/merge that first.