Skip to content

MP6#116

Merged
mattheu merged 31 commits into
masterfrom
MP6
Dec 2, 2013
Merged

MP6#116
mattheu merged 31 commits into
masterfrom
MP6

Conversation

@mattheu
Copy link
Copy Markdown
Member

@mattheu mattheu commented Nov 10, 2013

MP6 has landed in trunk.

This is a great opportunity to have a real good spring clean of all the styles.

  • MP6-ify the styles. Mainly new buttons & more whitespace.
  • More structure. Use @import to include a stylesheet for each field.
  • Remove styles that are old or duplicate. Was quite a lot of this!.
  • Remove some inline styles & non-prefixed class names

I am still loading the old styles for WP pre 3.8. This allows us to merge this ASAP and those using trunk and MP6 plugin will get the benefits already. If we need to we can maintain a backwards compatable non MP6 stylesheet going forwards - we can do although it would be a pain.

TODO

  • test in IE - IE8+ are all fine. IE7 doesn't really seem supported by MP6 at this point.
  • check backwards compatability.

Note I have merged #115 into this already. So review/merge that first.

@willmot
Copy link
Copy Markdown
Member

willmot commented Nov 11, 2013

Nice!

@Mte90
Copy link
Copy Markdown

Mte90 commented Nov 13, 2013

WOW
when will be integrated this code into master branch?

@mattheu mattheu mentioned this pull request Nov 20, 2013
@mattheu mattheu mentioned this pull request Nov 24, 2013
@ghost ghost assigned joehoyle Nov 26, 2013
@mattheu
Copy link
Copy Markdown
Member Author

mattheu commented Nov 26, 2013

I'm happy with this. Good to get a review/merge (cc @joehoyle )

@mattheu
Copy link
Copy Markdown
Member Author

mattheu commented Nov 26, 2013

Fixed conflicts.

@joehoyle
Copy link
Copy Markdown
Member

@mattheu coudl we get some screenshots?

@ghost ghost assigned mattheu Nov 26, 2013
@mattheu
Copy link
Copy Markdown
Member Author

mattheu commented Nov 26, 2013

Generally.... pretty similar. Tweaks to fit the MP6 styles. More whitespace + some borders. Impoved button styles. Rewritten CSS though so its a bit more usable.

Its a big screenshot but here goes...

cmb-mp6ified

@mattheu
Copy link
Copy Markdown
Member Author

mattheu commented Dec 1, 2013

@joe - Bump - any chance of a review/merge. 3.8 isn't far off now.

Comment thread classes.fields.php Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need the & me thinks, why did you need that?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this needed in order to use the value returned by get_fields() as a reference to $this->fields right? Am I doing it wrong?

I'm going to merge anyway because this was actually added already - I just moved the function in this PR. I would like to ensure I'm doing it the right way.

@joehoyle
Copy link
Copy Markdown
Member

joehoyle commented Dec 2, 2013

Looks good, couple of small notes

mattheu added a commit that referenced this pull request Dec 2, 2013
@mattheu mattheu merged commit 9180d2e into master Dec 2, 2013
@mattheu mattheu deleted the MP6 branch December 2, 2013 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants