Wrong Behaviour: Values are converted to arrays

[mattheu]

Hi guys,

So I update the library to the latest version and I had some issues after that. As I tracked them down, I saw that what used to be as a normal value is now returned as an array. Please see the attached image:

Is this intended behaviour or is it a bug?

PS: This is a repeatable group.

[bearded-avenger]

same issue here

http://screencast.com/t/NQvi1VVNxH

[bearded-avenger]

I reverted to an earlier version and issue isn't present.

[banago]

That's the point - it changed behaviour.

[bearded-avenger]

I'm just backing you in having the same problem. That ok?

[banago]

That's awesome! Did I come through to harsh or something? :)

[bearded-avenger]

I apologize I likely read that wrong. All good. :)

[banago]

Where are these guys @mattheu and @joehoyle?

[joehoyle]

@mattheu do you know if the resent JS refactor could have caused this? I think this also prompts discussion on doing a release cycle / stable tags.

[bearded-avenger]

I think it was this pull request

b43d588

And I definitely agree about a release cycle.

[banago]

We have to do a release cycle eventually. But my client is waiting too. :)

[joehoyle]

@banago can you not just checkout an older revision where it was working for now?

[mattheu]

I'll take a look tonight

[banago]

Sure but I like the improved radio box styles. Other then that, there is nothing holding me off. I suggest the whole master branch reverts to an older version since people might be grabbing the library and getting the wrong results.

[joehoyle]

@banago any reverting we can do to fix the issue, you can do locally of course. Waiting to hear from @mattheu on what he finds before reverting master.

[banago]

@joehoyle yeah yeah, sure. That was just a suggestion - I care about this project that much. :)

[joehoyle]

@banago cool, I appreciate the effort in reporting the issue and digging into it too - sorry about breaking your site!

[mattheu]

My apologies for breaking stuff. I am fully to blame for this!

Can you check whether this PR fixes the issue? I think it is done on save so you will need to just need to resave the post

[banago]

@mattheu the PR fixed the problem. And yes, all it was required was a resave. I think this is good to merge.

[mattheu]

updated unit tests.

Thanks.