Skip to content

Fix gmap grouped field data structure #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeselander merged 5 commits into from
Mar 20, 2017
Merged

Fix gmap grouped field data structure #423

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f400a3
Fix #422 for gmap grouped field data structure
dan-westall Mar 17, 2017
4608b40
Fix code style
dan-westall Mar 17, 2017
c5307d6
Add check for data formats
dan-westall Mar 17, 2017
dabe52e
Add fix for historical data structure transition
dan-westall Mar 17, 2017
f564d38
Fixed comments
mikeselander Mar 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions fields/class-cmb-field.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,8 +496,24 @@ public function display() {
$this->description();

$i = 0;
if ( isset( $this->args['type'] ) && 'gmap' == $this->args['type'] ) {
$values = array( $values );

// If the map field is not repeatable then we need to wrap it within an
// array to remove difference in data structure between a repeater field and normal
if ( isset( $this->args['type'] ) && 'gmap' === $this->args['type'] ) {
if ( $this->args['repeatable'] === false && ! isset( $this->parent ) ) {
$values = array( $values );
}

// If its within a group then we need to unwrap it from the group,
if ( $this->args['repeatable'] === false && isset( $this->parent ) ) {
$values = $values[0];

// Transitions code for data formats see:
// https://github.com/humanmade/Custom-Meta-Boxes/issues/422
if ( count( $values ) !== 1 ) {
$values = array( $values );
}
}
}

foreach ( $values as $key => $value ) {
Expand Down