Skip to content

Use site language when loading Google Maps API#439

Merged
mikeselander merged 1 commit into
humanmade:developfrom
barryceelen:fix-gmaps-language
Oct 11, 2017
Merged

Use site language when loading Google Maps API#439
mikeselander merged 1 commit into
humanmade:developfrom
barryceelen:fix-gmaps-language

Conversation

@barryceelen
Copy link
Copy Markdown
Contributor

@barryceelen barryceelen commented Sep 20, 2017

The Google Maps field always shows in english. This pull request uses get_locale() to pass along a language parameter when getting the API script.

I have:

  • Run WordPress VIP PHPCS check and code parses without errors
  • Added any new PHPUnit tests
  • Run PHPUnit and all tests are passing after adding any necessary new tests
  • Tested feature/bugfix on single and multisite install

@mikeselander

Copy link
Copy Markdown
Contributor

@mikeselander mikeselander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikeselander mikeselander merged commit 4a14925 into humanmade:develop Oct 11, 2017
@barryceelen barryceelen deleted the fix-gmaps-language branch October 11, 2017 09:17
@barryceelen
Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants