Remove old code#92
Merged
Merged
Conversation
Member
|
It's there to support meta boxes on in the edit post screen. Hence you call |
Member
Author
|
ah right I see. I couldn't work out where this was used. I guess I don't want to break any compatability. Perhaps this could be moved to a new file and documented a little as a temporary measure? Just so I don't decide it can be deleted again! 👍 Meta boxes anywhere should definitely be the next big thing. |
Member
|
Yeah new file makes sense, with some comment to describe what it's doing. |
Member
Author
|
Updated |
Member
|
@mattheu doesn't merge cleanly |
Conflicts: custom-meta-boxes.php
Member
Author
|
updated again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this is old code that is no longer used. Its pretty confusing that its still here. I think we should remove it.
@joehoyle Do you know of any reason not to do this?
review #merge