Allow enforcing 2fa for super adminns#6
Merged
Conversation
roborourke
approved these changes
Feb 14, 2022
roborourke
left a comment
roborourke
left a comment
There was a problem hiding this comment.
Besides the suggestion this looks good to me
| public static function global_force_2fa_by_role_field() { | ||
| $forced_roles = self::get_forced_user_roles(); | ||
| $is_universally_forced = self::get_universally_forced_option(); | ||
| $roles = array_merge( [ 'super-admin' => [ 'name' => 'Super Administrator' ] ], get_editable_roles() ); |
There was a problem hiding this comment.
Does this need to be translatable? There's a core string for 'Super Admin' so I'd use that I think.
Suggested change
| $roles = array_merge( [ 'super-admin' => [ 'name' => 'Super Administrator' ] ], get_editable_roles() ); | |
| $roles = array_merge( [ 'super-admin' => [ 'name' => __( 'Super Admin' ) ] ], get_editable_roles() ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref humanmade/altis-security#144