Properly handle on_created_account related to inc_account_nonce logic#151
Merged
dmitrylavrenov merged 6 commits intoh-polkadot-v0.9.42from Feb 3, 2025
Merged
Properly handle on_created_account related to inc_account_nonce logic#151dmitrylavrenov merged 6 commits intoh-polkadot-v0.9.42from
on_created_account related to inc_account_nonce logic#151dmitrylavrenov merged 6 commits intoh-polkadot-v0.9.42from
Conversation
MOZGIII
reviewed
Feb 1, 2025
MOZGIII
approved these changes
Feb 1, 2025
MOZGIII
left a comment
MOZGIII
left a comment
There was a problem hiding this comment.
The semantics of the change is great! There's a small nit regarding the wording of vars, but otherwise it is much more reasonable.
Also, we can reduce the amount of storage calls by one if we do the check at the Account::<T>::mutate callback.
MOZGIII
reviewed
Feb 2, 2025
Co-authored-by: MOZGIII <mike-n@narod.ru>
MOZGIII
approved these changes
Feb 2, 2025
quasiyoke
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decided to rethink about #147 and all conversations we had.
Suggest to move decision making logic to doing checks whether account was existed before or not instead of checking account data values inside
Account::<T>::mutate