Introduce external account provider into pallet_evm#61
Merged
dmitrylavrenov merged 8 commits intolocked/polkadot-v0.9.38from May 10, 2023
Merged
Conversation
MOZGIII
reviewed
May 8, 2023
MOZGIII
reviewed
May 8, 2023
MOZGIII
approved these changes
May 8, 2023
MOZGIII
left a comment
There was a problem hiding this comment.
The code structure looks fine!
A few notes:
- We might want to push the trait declaration to a separate crate to keep cleaner abstraction isolation.
- The trait documentation should sufficiently explain what the trait is intended for, and each method's docs explain what it does, when it can be called and why, etc. This is tricky because we can't be too specific as to not refer to a particular implementation, which can possibly update out of sync from the documentation we currently discuss. So we need to be quite abstract in regards to mentioning the code parts (i.e. function names and etc) and explain things in terms of general logic instead.
Let's discuss if in doubt.
Otherwise, this very looks good!
Oh, and one more thing: we need to adjust the rest of the crates too: precompiles, etc... Or is it just all we need?
Author
The trait related docs have been improved. Your suggestion would be great as well! |
MOZGIII
approved these changes
May 10, 2023
32 tasks
dmitrylavrenov
added a commit
that referenced
this pull request
Oct 12, 2023
* Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods
dmitrylavrenov
added a commit
that referenced
this pull request
Oct 12, 2023
* Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods
dmitrylavrenov
added a commit
that referenced
this pull request
Oct 19, 2023
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Oct 31, 2023
* Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods
dmitrylavrenov
added a commit
that referenced
this pull request
Oct 31, 2023
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Nov 22, 2023
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Nov 22, 2023
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Dec 19, 2023
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Dec 19, 2023
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Dec 19, 2023
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Feb 19, 2024
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Feb 19, 2024
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Mar 6, 2024
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Jun 10, 2024
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Jun 10, 2024
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Oct 21, 2024
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Jun 16, 2025
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Jun 16, 2025
…olkadot v1.0.0 (#166) * Support external account provider (#83) (#92) (#97) (#104) * Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm * Rename remove_account to on_account_self_destruct at AccountProvider interface (#155)
dmitrylavrenov
added a commit
that referenced
this pull request
Jun 16, 2025
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Jun 16, 2025
* Support external account provider (#83) (#92) (#97) (#104) * Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm * Rename remove_account to on_account_self_destruct at AccountProvider interface (#155) * Use Nonce instead of Index
dmitrylavrenov
added a commit
that referenced
this pull request
Jun 16, 2025
* Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov
added a commit
that referenced
this pull request
Jun 16, 2025
* Support external account provider (#83) (#92) (#97) (#104) * Introduce external account provider into `pallet_evm` (#61) * Introduce AccountProvider interface * Apply account provider logic for tests and template * Fix docs for remove_account method * Fix missing docs * Improve docs for account provider trait * Fix docs for native system account provider * Move account provider logic to separate mod * Add details docs for methods * Move `AccountProvider` interface into `fp-em` (#71) * Move account provider interface into fp-em * Implement AccountProvider interface for EvmSystem * Revert formatter * Move NativeSystemAccountProvider to pallet-evm * Rename remove_account to on_account_self_destruct at AccountProvider interface (#155) * Use Nonce instead of Index * Add account provider logic to introduced precompiles set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To simplify #60.
The frontier tests have been passed successfully.