Skip to content

Add snapshot tests for other subcommands --help output#1034

Merged
dmitrylavrenov merged 11 commits intomasterfrom
help-subcommands-checks
May 12, 2024
Merged

Add snapshot tests for other subcommands --help output#1034
dmitrylavrenov merged 11 commits intomasterfrom
help-subcommands-checks

Conversation

@dmitrylavrenov
Copy link
Contributor

Closes #1000

@dmitrylavrenov dmitrylavrenov requested a review from MOZGIII May 9, 2024 13:06
Copy link
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to place those fixtures into a subdir

@dmitrylavrenov dmitrylavrenov force-pushed the help-subcommands-checks branch from 2da344a to 1480bf0 Compare May 10, 2024 17:37
@dmitrylavrenov
Copy link
Contributor Author

We probably want to place those fixtures into a subdir

Reimplemented a little bit and moved to separate subdirectories all help related commands.

@dmitrylavrenov dmitrylavrenov requested a review from MOZGIII May 10, 2024 17:47
@dmitrylavrenov dmitrylavrenov added this pull request to the merge queue May 12, 2024
Merged via the queue into master with commit 6cbd3aa May 12, 2024
@dmitrylavrenov dmitrylavrenov deleted the help-subcommands-checks branch May 12, 2024 12:37
dmitrylavrenov added a commit that referenced this pull request May 13, 2024
* Add keys related fixtures and modify help check script

* Properly handle base help command

* Add rest fixtures

* Move help fixtures to separate folder

* Fix variable usage

* Add bioauth and evm related fixtures

* Remove redundandat arg

* Remove comment

* Extract the snapshot matching into an fn

* Further refactor the help test

* Improve extract_subcommands awk script

---------

Co-authored-by: MOZGIII <mike-n@narod.ru>
dmitrylavrenov added a commit that referenced this pull request May 13, 2024
* Add keys related fixtures and modify help check script

* Properly handle base help command

* Add rest fixtures

* Move help fixtures to separate folder

* Fix variable usage

* Add bioauth and evm related fixtures

* Remove redundandat arg

* Remove comment

* Extract the snapshot matching into an fn

* Further refactor the help test

* Improve extract_subcommands awk script

---------

Co-authored-by: MOZGIII <mike-n@narod.ru>
dmitrylavrenov added a commit that referenced this pull request Jun 20, 2024
* Add keys related fixtures and modify help check script

* Properly handle base help command

* Add rest fixtures

* Move help fixtures to separate folder

* Fix variable usage

* Add bioauth and evm related fixtures

* Remove redundandat arg

* Remove comment

* Extract the snapshot matching into an fn

* Further refactor the help test

* Improve extract_subcommands awk script

---------

Co-authored-by: MOZGIII <mike-n@narod.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add snapshot tests for other subcommands --help output

2 participants