Remove migrations used to properly initialize storage versions at humanode-runtime#1431
Merged
dmitrylavrenov merged 1 commit intomasterfrom Feb 10, 2025
Conversation
MOZGIII
approved these changes
Feb 10, 2025
dmitrylavrenov
deleted the
remove-migrations-for-storage-version-initializer
branch
Contributor
|
In hindsight, we should keep such migrations for waaayy longer, like a 100 runtime versions or sth. Ideally for as long as we can maintain them without too much hassle. Rationale is if someone upgrades from 123 to 125 jumping over 124 they'll miss this migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage versions have been properly initialized for
pallet-dummy-precompiles-codeandpallet-balanced-currency-swap-bridges-initializerat mainnet with latest runtime upgrade to 123spec_version