Skip to content

Implement migration logic to clean consumed auth ticket nonces at pallet-bioauth#1436

Merged
dmitrylavrenov merged 12 commits intomasterfrom
consumed-auth-ticket-nonces-cleaner
Feb 18, 2025
Merged

Implement migration logic to clean consumed auth ticket nonces at pallet-bioauth#1436
dmitrylavrenov merged 12 commits intomasterfrom
consumed-auth-ticket-nonces-cleaner

Conversation

@dmitrylavrenov
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov commented Feb 12, 2025

Successfully executed sudo runtime upgrade transaction using patched fork based on 11509363 block.

before upgrade

Screenshot 2025-02-12 at 14 57 59

logs during upgrade

2025-02-12 14:58:42 🙌 Starting consensus session on top of parent 0x7b62c0b23ebd689e1a6d6fafbf85e1e390c390739310806b45148a80f2a20c9b    
2025-02-12 14:58:42 🎁 Prepared block for proposing at 9 (4619 ms) [hash: 0x7567e9d759705e0ecc735243e93585f63302b3c501f3bc1e092340188dea78e4; parent_hash: 0x7b62…0c9b; extrinsics (1): [0xa33e…eb74]]    
2025-02-12 14:58:43 💤 Idle (0 peers), best: #8 (0x7b62…0c9b), finalized #0 (0x2bb9…85ba), ⬇ 0 ⬆ 0    
2025-02-12 14:58:43 Removed 80814 Offences keys 🧹    
2025-02-12 14:58:43 Bioauth: Running migration to clean consumed auth ticket nonces except ones related to current generation    
2025-02-12 14:58:43 Bioauth: Removed 47908 consumed auth ticket nonces    
2025-02-12 14:58:43 ⚠️ HumanodeSession declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`    
2025-02-12 14:58:43 Running migration to v1 from StorageVersion(1)    
2025-02-12 14:58:43 Already at version 1, nothing to do    
2025-02-12 14:58:43 ⚠️ Ethereum declares internal migrations (which *might* execute). On-chain `StorageVersion(0)` vs current storage version `StorageVersion(0)`    
2025-02-12 14:58:43 ⚠️ BalancedCurrencySwapBridgesInitializer declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`    
2025-02-12 14:58:43 ⚠️ EvmBalancesErc20Support declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`    
2025-02-12 14:58:43 ⚠️ DummyPrecompilesCode declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`    
2025-02-12 14:58:48 💤 Idle (0 peers), best: #8 (0x7b62…0c9b), finalized #0 (0x2bb9…85ba), ⬇ 0 ⬆ 0    
2025-02-12 14:58:48 🎁 Prepared block for proposing at 9 (4543 ms) [hash: 0x317cbbf853b78e11caae9131cda11028f3e2967d433426a971fcb83e90182e7e; parent_hash: 0x7b62…0c9b; extrinsics (1): [0x0074…9c5d]]    
2025-02-12 14:58:48 🔖 Pre-sealed block for proposal at 9. Hash now 0x320c5ad1004ed5c7dddd41be444b5ccc09870b074248293273cf9a03b11aa835, previously 0x317cbbf853b78e11caae9131cda11028f3e2967d433426a971fcb83e90182e7e.    
2025-02-12 14:58:48 ✨ Imported #9 (0x320c…a835)

after upgrade

Screenshot 2025-02-12 at 14 59 01

@dmitrylavrenov dmitrylavrenov marked this pull request as ready for review February 12, 2025 09:06
@dmitrylavrenov dmitrylavrenov changed the title Implement migration logic to clean consumed auth ticket nonces at pallet-biauth Implement migration logic to clean consumed auth ticket nonces at pallet-bioauth Feb 12, 2025
@MOZGIII
Copy link
Contributor

MOZGIII commented Feb 12, 2025

If we want to wipe it clean we'd need to wait for biometric server rotation. Can we clear out just the old generations?

@dmitrylavrenov dmitrylavrenov force-pushed the consumed-auth-ticket-nonces-cleaner branch 2 times, most recently from ec2863a to d5b58ca Compare February 12, 2025 11:56
@dmitrylavrenov
Copy link
Contributor Author

dmitrylavrenov commented Feb 12, 2025

If we want to wipe it clean we'd need to wait for biometric server rotation. Can we clear out just the old generations?

Reimplemented keeping just consumed auth ticket nonces related to current generation.

@dmitrylavrenov dmitrylavrenov force-pushed the consumed-auth-ticket-nonces-cleaner branch from 1228f36 to b790e43 Compare February 17, 2025 12:03
Copy link
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@dmitrylavrenov dmitrylavrenov force-pushed the consumed-auth-ticket-nonces-cleaner branch from 988281d to 650caa6 Compare February 18, 2025 10:28
@dmitrylavrenov dmitrylavrenov added this pull request to the merge queue Feb 18, 2025
@dmitrylavrenov dmitrylavrenov removed this pull request from the merge queue due to a manual request Feb 18, 2025
Co-authored-by: MOZGIII <mike-n@narod.ru>
@dmitrylavrenov dmitrylavrenov force-pushed the consumed-auth-ticket-nonces-cleaner branch from 9b97d27 to 9981191 Compare February 18, 2025 12:30
@dmitrylavrenov dmitrylavrenov added this pull request to the merge queue Feb 18, 2025
Merged via the queue into master with commit 383e191 Feb 18, 2025
21 checks passed
@dmitrylavrenov dmitrylavrenov deleted the consumed-auth-ticket-nonces-cleaner branch February 18, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants