Implement ethereum explicitly related currency swap logic to make Native-to-EVM Bridge transactions visible via Ethereum RPC#1449
Merged
dmitrylavrenov merged 102 commits intomasterfrom Mar 26, 2025
Conversation
MOZGIII
reviewed
Feb 19, 2025
MOZGIII
reviewed
Feb 19, 2025
dmitrylavrenov
commented
Feb 20, 2025
dmitrylavrenov
commented
Feb 20, 2025
d203de1 to
c7c315c
Compare
MOZGIII
reviewed
Feb 20, 2025
MOZGIII
requested changes
Feb 20, 2025
Contributor
MOZGIII
left a comment
There was a problem hiding this comment.
This looks good!
If we add the E2E tests to verify that the solution works overall, and unit tests with mock runtime (as we usually do) to test the niche cases (zero transfer, etc) and for tight regression control - I think we ship it pretty much right away
MOZGIII
reviewed
Feb 20, 2025
MOZGIII
reviewed
Feb 20, 2025
MOZGIII
reviewed
Feb 20, 2025
4c9425c to
01e492c
Compare
MOZGIII
reviewed
Feb 20, 2025
MOZGIII
reviewed
Feb 20, 2025
f48f89e to
863a9aa
Compare
MOZGIII
reviewed
Feb 20, 2025
Contributor
|
Thinking about this, we should explicitly test, among other things, that the pot doesn't pay the fee for any tx with this flow. |
Contributor
Author
Tested manually that pot doesn't pay the fee - confirmed. Additionally will implement some unit tests and add this check to e2e test. |
MOZGIII
reviewed
Feb 20, 2025
b0e68a8 to
40e11f7
Compare
MOZGIII
reviewed
Feb 24, 2025
MOZGIII
approved these changes
Feb 24, 2025
e8980fc to
01643bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design thoughts
Currencyin favour of fungible related traits likeInspectandMutateTasks
P.S: do benchmarks at separate PR
PoC of visibility
transaction itself
transaction execution in explorer on Substrate RPC side
transaction execution in explorer on Ethereum RPC side
Very tiny ethereum explorer is used to verify visibility via Ethereum RPC