Fix CLI help for --rpc-url parameter#1498
Merged
Conversation
5bad183 to
d0068fb
Compare
dmitrylavrenov
approved these changes
Mar 24, 2025
MOZGIII
approved these changes
Mar 24, 2025
Contributor
|
Good find! |
d0068fb to
ec4a4c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI help for
--rpc-urlparameter doesn't match the current behavior if not passed. If you don't specify--rpc-url,--rpc-url-ngrok-detect,--rpc-url-unsetand--rpc-url-scheme-preferenceparameters, WebSocket will be chosen as the RPC URL scheme (CLI help points out HTTP). This was correctly specified in our documentation (in general, small correction regarding ports). The behavior was introduced in #355 Recent changes to 0.9.43 haven't affected this behavior significantly.