Perform the deduplication of the validators set#1621
Merged
MOZGIII merged 7 commits intointegrate-fixed-validators-setfrom Oct 9, 2025
Merged
Perform the deduplication of the validators set#1621MOZGIII merged 7 commits intointegrate-fixed-validators-setfrom
MOZGIII merged 7 commits intointegrate-fixed-validators-setfrom
Conversation
MOZGIII
force-pushed
the
integrate-fixed-validators-set-next
branch
from
160ccdd to
8c04f1b
Compare
MOZGIII
force-pushed
the
integrate-fixed-validators-set-next
branch
from
8c04f1b to
c66dc16
Compare
MOZGIII
changed the title
Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
quasiyoke
approved these changes
Oct 9, 2025
MOZGIII
added a commit
that referenced
this pull request
Dec 4, 2025
* Add dedupe utils * Implement validator deduplication based on account id and the first-in order * Fix the doc comment on the DedupeKeyExtractor::Output * Fixed doc comment on DedupeIter::dedupe_key_extractor * Apply suggestion from @dmitrylavrenov Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com> * Add a test * Remove the broken impl (doesn't work either way) --------- Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
* Integrate pallet-fixed-validators-set with pallet-humanode-session * Integrate pallet-fixed-validators-set into pallet-humanode-offences * Integrate pallet-fixed-validators-set into humanode-runtime * Integrate pallet-fixed-validators-set into humanode-peer * Recompute the benches * Use computed benches * Add more checks to verify slashing logic at a corresponding runtime test (#1620) Add more checks to verify slashin logic at a corresponding runtime test * Adjust the preexisting tests to include fixed validators set * Add duplicates test * Perform the deduplication of the validators set (#1621) * Add dedupe utils * Implement validator deduplication based on account id and the first-in order * Fix the doc comment on the DedupeKeyExtractor::Output * Fixed doc comment on DedupeIter::dedupe_key_extractor * Apply suggestion from @dmitrylavrenov Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com> * Add a test * Remove the broken impl (doesn't work either way) --------- Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com> * Add the check for the fixed validators set --------- Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue of incorrect duplication of the validators when they are present in more than one "source"; while we only had bootnodes this was hardly an issue, but it becomes quite important when we have both bioauth and fixed validators set.
There is, however, an alternative solution that wouldn't require deduplication - that is, if we have an explicit switch at the
pallet-humanode-sessionon which mode to use. As in either we use bioauth or fixed validators set.