Skip to content

FaceTec integration corrections#39

Merged
MOZGIII merged 42 commits intomasterfrom
facetec-fixes
Jul 27, 2021
Merged

FaceTec integration corrections#39
MOZGIII merged 42 commits intomasterfrom
facetec-fixes

Conversation

@MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Jul 3, 2021 •
edited
Loading

This PR applies various corrections to our FaceTec integration.

To do:

  • move to the FaceTec Custom Server to enable proper reset to make tests run properly just hard-coded the deletion of the individual enrollements

@MOZGIII MOZGIII force-pushed the facetec-fixes branch 2 times, most recently from 65c9722 to ee0dc67 Compare July 3, 2021 16:23
@MOZGIII MOZGIII force-pushed the facetec-fixes branch 6 times, most recently from aefed9b to 06dc7c2 Compare July 23, 2021 16:56
dmitrylavrenov
dmitrylavrenov reviewed Jul 26, 2021
View reviewed changes
dmitrylavrenov
dmitrylavrenov reviewed Jul 26, 2021
View reviewed changes
@MOZGIII MOZGIII marked this pull request as ready for review July 26, 2021 16:28
@MOZGIII MOZGIII force-pushed the facetec-fixes branch 2 times, most recently from 4d2712f to 7900a37 Compare July 27, 2021 13:01
MOZGIII added 14 commits July 27, 2021 22:13
@MOZGIII
Allow response body inspection for JSON parsing errors at facetec-api…
9507ba1 
…-client
@MOZGIII
Implement response body error inspection mechanism at facetec api client
07a14d2
@MOZGIII
Implement a logging inspector at the robonode
cb485f5
@MOZGIII
Share the test client init code at facetec api client
3b539cb
@MOZGIII
Utilize use paths for context at facetec api client
3cd7872
@MOZGIII
Fix a couple of the facetec response handling bugs at the robonode-se…
c458959 
…rver
@MOZGIII
Correct the facetec api client enrollment 3d call error handling
4caa989
@MOZGIII
Add an Execution ID to the robonode logic
2cce03b
@MOZGIII
Another correction to the facetec api client and robonode logic
31e865a
@MOZGIII
Another test case and correction at the facetec api client
1d26d57
@MOZGIII
Log the unsuccessful facetec server enroll responses
baf0c12
@MOZGIII
Apparently group parameter can not be empty
9116f85 
Thanks for the docs, FaceTec
@MOZGIII
Refactor robonode server structure
8d8953d
@MOZGIII
Add an unexpected_error_in_success_response_deserialization
fe334c2
MOZGIII and others added 23 commits July 27, 2021 22:16
@MOZGIII
Enable tracing in tests
43c8273
@MOZGIII
Pass the reset call body
705661b
@MOZGIII
Add support for injecting fake IP address into the FaceTec API requests
ea26288
@MOZGIII
Add tracing to robonode logic for facetec responses
104b910
@MOZGIII
Correct the first_authenticate test logic
3b97cad
@MOZGIII
Add serde_util::Either at facetec api client
6a3f52f
@MOZGIII
Add support for processing errors in success responses at db_search
026aad9
@MOZGIII
Trace facetec server reset
9ece384
@MOZGIII
Add raw response body inspection to FaceTec API client
1b62cc9
@MOZGIII
Add another test case to the logic
bc45452
@MOZGIII
Fix the bug in the logic
363fdbe
@MOZGIII
Add an assertion to guarantee that we the enroll and auth liveness da…
e164b7b 
…ta are different
@MOZGIII
Drop the responses when they're not needed
67aaa17
@MOZGIII
Add a handler for the FaceTec 3D DB search response
6ffebb7
@MOZGIII
Lower the risk of parsing error by cutting extra details from the 3D …
9eaa708 
…DB search response
@MOZGIII
Add db_search_result_adapter at op_authenticate
190c62c
@MOZGIII @dmitrylavrenov
Update crates/facetec-api-client/src/db_search.rs
a80deff 
Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
@MOZGIII @dmitrylavrenov
Update crates/facetec-api-client/src/response_body_error.rs
b38a935 
Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
@MOZGIII
Add log event to the enroll_authenticate test
264730f
@MOZGIII
Add 3D DB deletion endpoint
dbcd996
@MOZGIII
Clear the known facetec 3D DB entry at robonode tests
f68588c
@MOZGIII
Use a real response from the facetec server at 3D DB enroll
d5c7d94 
For some reason, our FaceTec server doesn't provide
the externalDatabaseRefID field in the response.
The test server and postman test suite both do provide it.
We don't really need it, so it's simply removed from the response,
but it looks like we can't trust any of the FaceTec docs / test
servers.
@MOZGIII
Cleanup all of the public keys used in the tests
9caff3c
@MOZGIII MOZGIII enabled auto-merge (squash) July 27, 2021 19:26
@MOZGIII MOZGIII merged commit 9bd7737 into master Jul 27, 2021
@MOZGIII MOZGIII deleted the facetec-fixes branch July 27, 2021 19:38
@MOZGIII MOZGIII mentioned this pull request Aug 16, 2021
Closed
This was referenced Aug 26, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitrylavrenov dmitrylavrenov dmitrylavrenov approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MOZGIII @dmitrylavrenov