Conversation
c6800dc to
1f43adf
Compare
2e0bded to
0181649
Compare
Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
Contributor
Author
|
We'll be merging this soon, and moving on to building things on top of this PR. Please review asap. |
dmitrylavrenov
approved these changes
Aug 3, 2022
Contributor
dmitrylavrenov
left a comment
There was a problem hiding this comment.
Great! I was enjoyed walking through test cases. Looks like that we've covered all possible test cases for claim logic.
Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
Contributor
|
Looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the token claiming logic.
See #430.
To do
claimcall: success without vestingclaimcall: success with vestingclaimcall: eth signature recovery failureclaimcall: eth signature recovers invalid eth addressclaimcall: locking under vesting fails (returns an error)claimcall: no claim existsclaimcalls, but not the existential balance of the potclaimcallclaimcall