Skip to content

Token claims#427

Merged
MOZGIII merged 41 commits intomasterfrom
claims
Aug 3, 2022
Merged

Token claims#427
MOZGIII merged 41 commits intomasterfrom
claims

Conversation

@MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Jul 26, 2022

This PR implements the token claiming logic.

See #430.


To do

  • basic implementation
  • add pallet account to hold the funds
  • check that the pallet account's balance is properly initialized at genesis build
  • check that the total claimable balance is matching the expected value
  • test claim call: success without vesting
  • test claim call: success with vesting
  • test claim call: eth signature recovery failure
  • test claim call: eth signature recovers invalid eth address
  • test claim call: locking under vesting fails (returns an error)
  • test claim call: no claim exists
  • test that we can consume all the claimable balance with claim calls, but not the existential balance of the pot
  • bench: interface to runtime
  • bench: implement test interface for mock runtime
  • bench: claim call
  • doc pallet
  • doc claim call

@MOZGIII MOZGIII marked this pull request as draft July 26, 2022 13:56
@MOZGIII MOZGIII force-pushed the claims branch 6 times, most recently from c6800dc to 1f43adf Compare July 27, 2022 16:53
@MOZGIII MOZGIII force-pushed the claims branch 2 times, most recently from 2e0bded to 0181649 Compare July 28, 2022 12:09
@MOZGIII MOZGIII marked this pull request as ready for review August 1, 2022 16:01
Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
@MOZGIII
Copy link
Contributor Author

MOZGIII commented Aug 2, 2022

We'll be merging this soon, and moving on to building things on top of this PR. Please review asap.

Copy link
Contributor

@dmitrylavrenov dmitrylavrenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I was enjoyed walking through test cases. Looks like that we've covered all possible test cases for claim logic.

@MOZGIII MOZGIII mentioned this pull request Aug 3, 2022
MOZGIII and others added 2 commits August 3, 2022 22:07
Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
@MOZGIII MOZGIII merged commit e56b550 into master Aug 3, 2022
@MOZGIII MOZGIII deleted the claims branch August 3, 2022 23:03
Copy link
Contributor

@intendednull intendednull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@henrybyhee
Copy link
Contributor

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants