Skip to content

Vesting#429

Merged
MOZGIII merged 36 commits intomasterfrom
vesting
Aug 15, 2022
Merged

Vesting#429
MOZGIII merged 36 commits intomasterfrom
vesting

Conversation

@MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Aug 3, 2022 •
edited
Loading

This PR implements vesting logic.

See #430.

To do

  • implementation
    • pallet-vesting (core pallet)
    • vesting-scheduling-timestamp (timestamp driver)
    • vesting-schedule-linear (linear schedule with cliff)
    • pallet-chain-start-moment (chain start moment provider)
  • pallet-vesting tests
    • lock_under_vesting fn
    • unlock call
    • events work in tests
  • vesting-schedule-linear tests
    • filly locked during the cliff period
    • filly unlocked after the cliff + vesting period
    • linearly unlocks across the vesting period
    • rounds towards locking less than more (to floor)
    • math edge cases (overflows, etc)
    • fully unlocked when the vesting period is zero
  • vesting-scheduling-timestamp tests
    • test that we get an error when the now timestamp is before starting point
    • test that the schedules work with starting points other than 20
    • test that we can vary the starting point and the now together and the results will be the same (with edge cases)
    • test the computation of duration since starting point (regular + edge cases and errors)
    • fix races in tests
  • pallet-chain-start-moment tests
  • pallet-vesting benches
  • docs

@MOZGIII MOZGIII force-pushed the vesting branch 4 times, most recently from 0f2a7ec to 903a2e6 Compare August 3, 2022 23:05
@MOZGIII MOZGIII mentioned this pull request Aug 3, 2022
Closed
@MOZGIII MOZGIII force-pushed the vesting branch 6 times, most recently from eff9225 to 8aac870 Compare August 5, 2022 18:52
dmitrylavrenov
dmitrylavrenov reviewed Aug 8, 2022
View reviewed changes
dmitrylavrenov
dmitrylavrenov reviewed Aug 8, 2022
View reviewed changes
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current implementation looks great to me. Thanks for clear code and documentation.
Amazing!

Everything is clear.

@MOZGIII MOZGIII force-pushed the vesting branch 7 times, most recently from a54fc01 to d0c838e Compare August 9, 2022 10:40
@MOZGIII MOZGIII marked this pull request as ready for review August 9, 2022 12:58
@MOZGIII MOZGIII force-pushed the vesting branch 2 times, most recently from 07af659 to 2e32bcb Compare August 9, 2022 14:33
@dmitrylavrenov dmitrylavrenov mentioned this pull request Aug 11, 2022
Closed
dmitrylavrenov
dmitrylavrenov reviewed Aug 11, 2022
View reviewed changes
dmitrylavrenov
dmitrylavrenov reviewed Aug 11, 2022
View reviewed changes
dmitrylavrenov
dmitrylavrenov reviewed Aug 11, 2022
View reviewed changes
MOZGIII and others added 26 commits August 15, 2022 16:34
@MOZGIII
Make the starting point value optional at the timestamp driver
775fe8f
@MOZGIII
Fix the chain start moment capture logic and tests
871cc88
@MOZGIII
Correct the edge case calculations at SimpleFracScaler
c67a8c0
@MOZGIII
Implement tests and better error communication at FracScale
c622663
@MOZGIII
Add test for linear schedule
cc67f75
@MOZGIII
Reserve the weight at pallet-chain-start-moment
f1a3cbd
@MOZGIII
Add logic_all_zeroes test at crates/vesting-schedule-linear/src/lib.rs
6eca387
@MOZGIII
Add vesting-scheduling-timestamp tests
2aa0832
@MOZGIII
Revert "Comment out the event checks temporarily"
cf932b4 
This reverts commit 9984b74.
@MOZGIII
Enable the events in tests
e5acd7d
@MOZGIII
Drop thiserror from FracScaleError
b340fb4
@MOZGIII @dmitrylavrenov
Fix a typo at crates/pallet-vesting/src/lib.rs
2dff1f8 
Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
@MOZGIII
Drop unused error enum
dd81fdb
@MOZGIII
Add unlock_no_vesting_error test
7e4bbff
@MOZGIII @dmitrylavrenov
Fix a typo at crates/pallet-vesting/src/traits.rs
7ad2c60 
Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
@MOZGIII @intendednull @dmitrylavrenov
Fix the typos and logical mistakes in the comments
1ff41be 
Co-authored-by: Noah Corona <noah@coronasoftware.net>
Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
@MOZGIII
Correct the TIME_NOW_BEFORE_THE_STARTING_POINT_ERROR
4dc1087
@MOZGIII
Test the TIME_NOW_BEFORE_THE_STARTING_POINT_ERROR
08d3b8c
@MOZGIII
Proper loking of mocks at tests
24bd94a
@MOZGIII
Add multi_linear_scarting_point_check test
29135fb
@MOZGIII
Currect the multi_linear_returns_time_now_before_the_starting_point_e…
7a19ef4 
…rror
@MOZGIII
Revert "Currect the multi_linear_returns_time_now_before_the_starting…
3a1550f 
…_point_error"

This reverts commit fe5c989.
@MOZGIII
Fix the compute_result fn
73dc57f
@MOZGIII
Fix a typo at test name
b6a2580
@MOZGIII
Add multi_linear_returns_starting_point_not_defined_error_error test
2a61847
@MOZGIII
Correct the locking at vesting-scheduling-timestamp test mocks
1a23e19
@MOZGIII MOZGIII enabled auto-merge (squash) August 15, 2022 12:48
@MOZGIII MOZGIII merged commit 550df1b into master Aug 15, 2022
@MOZGIII MOZGIII deleted the vesting branch August 15, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitrylavrenov dmitrylavrenov dmitrylavrenov approved these changes

+2 more reviewers

@henrybyhee henrybyhee henrybyhee approved these changes

@intendednull intendednull intendednull approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MOZGIII @henrybyhee @intendednull @dmitrylavrenov