Token Claims EIP712 signature verification (and ethereum primitives switch)#431
Merged
Token Claims EIP712 signature verification (and ethereum primitives switch)#431
Conversation
dmitrylavrenov
approved these changes
Aug 8, 2022
Contributor
dmitrylavrenov
left a comment
There was a problem hiding this comment.
Looks good. Left some comments!
Contributor
Author
|
I decided we'd want to change the trait at token claims to only do the signer recovering instead of full verification, and move the verification out of the trait. It makes a lot of sense to do it like that, as the verification is not something one should be able to override. But we'll address it alter, I'll create an issue for this, and we can merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
eip712-token-claim, refactors theeip712code to enable more reuse, and switches the codebase to ethereum primitives crate.It also resolves the incorrect use of "EVM address" wording. The terms we have are EVM account and Ethereum address. Using the term "EVM address" is discouraged as confusing.
See #430.
eip712-token-claimTo do