Token claims and vesting runtime tests#445
Merged
dmitrylavrenov merged 64 commits intomasterfrom Aug 30, 2022
Merged
Conversation
MOZGIII
reviewed
Aug 17, 2022
MOZGIII
reviewed
Aug 17, 2022
MOZGIII
reviewed
Aug 17, 2022
MOZGIII
reviewed
Aug 17, 2022
MOZGIII
reviewed
Aug 17, 2022
MOZGIII
reviewed
Aug 17, 2022
MOZGIII
reviewed
Aug 17, 2022
MOZGIII
requested changes
Aug 17, 2022
Contributor
There was a problem hiding this comment.
Looks good so far, but a couple of changes are required.
- the
switch_blockhelper doesn't look right, we should probably invoke a more realistic block switching or none at all - the calls are tests via direct invocation, which doesn't test the signed ext, which we should do; I'll add the corresponding entries to the todo list
1 task
MOZGIII
reviewed
Aug 19, 2022
MOZGIII
reviewed
Aug 19, 2022
MOZGIII
reviewed
Aug 19, 2022
7c5b8bc to
e12449a
Compare
MOZGIII
reviewed
Aug 24, 2022
MOZGIII
reviewed
Aug 24, 2022
MOZGIII
reviewed
Aug 24, 2022
Contributor
MOZGIII
left a comment
There was a problem hiding this comment.
Great! Now I'll do a more thorough review on this code once again, and either request more changes or we'll be good to merge.
MOZGIII
reviewed
Aug 25, 2022
MOZGIII
reviewed
Aug 25, 2022
MOZGIII
reviewed
Aug 25, 2022
MOZGIII
reviewed
Aug 25, 2022
MOZGIII
reviewed
Aug 25, 2022
MOZGIII
reviewed
Aug 25, 2022
MOZGIII
reviewed
Aug 25, 2022
MOZGIII
requested changes
Aug 28, 2022
Contributor
There was a problem hiding this comment.
Tests for direct calls need to test for the errors too. Errors have to be tested for:
- direct calls
- dispatch validate
- dispatch pre/post
These three implementations are potentially different, so we need to ensure each of them handles errors (in their own way) correctly.
But still, to clarify, no tests for individual SignedExtensions are needed, only for the combined SignedExtra.
d4d234e to
a0fa379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime tests for token claims and vesting integration paritytech/substrate#441 .
To do
claimcall: claiming without vesting works:claimcall: claiming with vesting worksunlockcall: unlocking partial balance worksunlockcall: unlocking full balance worksclaimtransactionclaimtransactions, preventing them getting into the transaction pool