Skip to content

Separate balances between native and EVM accounts#673

Merged
dmitrylavrenov merged 70 commits intomasterfrom
separate-evm-accounts
Jul 10, 2023
Merged

Separate balances between native and EVM accounts#673
dmitrylavrenov merged 70 commits intomasterfrom
separate-evm-accounts

Conversation

@dmitrylavrenov
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov commented May 17, 2023 •
edited
Loading

Tasks

  • integrate pallet-evm-system
  • integrate pallet-evm-balances
  • define evm account provider at pallet-evm
  • disallow native origins calls for pallet-evm
  • introduce treasury and fees pot accounts for evm logic
  • use separate EvmBalances for type Currency with proper usage of OnChargeTransaction at pallet-evm
  • genesis config at tests
  • add test to check fixed supply after ethereum::transact call execution
  • define evm accounts config at chain spec
  • Change base from frame-evm-balances to locked/polkadot-v0.9.38

@dmitrylavrenov
Use frontier fork with frame-evm-balances
fe81abd
@dmitrylavrenov
Update frontier
62784a0
@dmitrylavrenov
Use own AccountId at precompile_set
57888c0
@dmitrylavrenov
Use AccountId from pallet_evm account provider for EvmTransactionCharger
bf5df71
@dmitrylavrenov
Update frontier
6802258
@dmitrylavrenov
Define and use evm treasury pot account at runtime
6aafeed
@dmitrylavrenov
Use DustRemoval for evm balances with evm treasury pot account
d394cf4
@dmitrylavrenov
Define and use evm fee pot account at runtime
b055ae2
@dmitrylavrenov
Fix EvmTransactionCharger with account id from account provider
d4a8375
@dmitrylavrenov
Use EvmTransactionCharger for pallet_evm with EvmBalances and EvmFeesPot
cdb3351
@dmitrylavrenov
Define full account id type
eabdca4
@dmitrylavrenov
Update frontier
ae3cc45
@dmitrylavrenov
Add evm fees and evm treasurey pot accounts into testnet genesis
cf83dbc
@dmitrylavrenov
Fix genesis_config test at runtime
5762e4a
@dmitrylavrenov
Fix fees tests at runtime
2430c22
@dmitrylavrenov
Fix claims and vesting tests
a7d9698
@dmitrylavrenov
Refactor genesis for fees tests
07cefa3
@dmitrylavrenov
Define a helper function to get EvmAccountId
4adc9c9
@dmitrylavrenov
Fix fixed_supply tests
dfb165e
@dmitrylavrenov
Use EnsureAddressNever for CallOrigin at pallet-evm
dd7ed4a
@dmitrylavrenov dmitrylavrenov force-pushed the separate-evm-accounts branch from 0a5e321 to dd7ed4a Compare May 27, 2023 20:13
@dmitrylavrenov dmitrylavrenov force-pushed the separate-evm-accounts branch from c1b1fef to db2ac8e Compare May 29, 2023 09:14
@dmitrylavrenov dmitrylavrenov marked this pull request as ready for review May 29, 2023 15:20
@dmitrylavrenov dmitrylavrenov requested a review from MOZGIII May 29, 2023 15:20
@MOZGIII
Copy link
Contributor

MOZGIII commented May 29, 2023

Great to see this progress, I'll take a deeper look later today

MOZGIII
MOZGIII reviewed May 30, 2023
View reviewed changes
@dmitrylavrenov dmitrylavrenov force-pushed the separate-evm-accounts branch from 7a02d83 to fed6101 Compare July 3, 2023 15:17
@dmitrylavrenov dmitrylavrenov force-pushed the separate-evm-accounts branch from c32e256 to 6d48f4c Compare July 3, 2023 18:56
@dmitrylavrenov dmitrylavrenov force-pushed the separate-evm-accounts branch from 6d48f4c to 88f01c7 Compare July 3, 2023 19:01
MOZGIII
MOZGIII reviewed Jul 4, 2023
View reviewed changes
MOZGIII
MOZGIII reviewed Jul 4, 2023
View reviewed changes
@MOZGIII MOZGIII self-requested a review July 4, 2023 14:26
@dmitrylavrenov dmitrylavrenov force-pushed the separate-evm-accounts branch from 0c72e91 to 0dda71e Compare July 4, 2023 16:52
MOZGIII
MOZGIII reviewed Jul 6, 2023
View reviewed changes
MOZGIII
MOZGIII approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the issues already brought up

I'm not at my best focus atm though, so please consider carefully inspecting the final diff again yourself just to be safe

@dmitrylavrenov dmitrylavrenov force-pushed the separate-evm-accounts branch 3 times, most recently from a7b86a9 to 6f6a816 Compare July 10, 2023 12:43
@dmitrylavrenov dmitrylavrenov force-pushed the separate-evm-accounts branch from 6f6a816 to aec3bd2 Compare July 10, 2023 12:49
@dmitrylavrenov dmitrylavrenov added this pull request to the merge queue Jul 10, 2023
Merged via the queue into master with commit 318aeab Jul 10, 2023
@dmitrylavrenov dmitrylavrenov deleted the separate-evm-accounts branch July 10, 2023 16:09
@MOZGIII MOZGIII mentioned this pull request Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MOZGIII MOZGIII MOZGIII approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmitrylavrenov @MOZGIII