Check existential deposit when creating an account during swap

[dmitrylavrenov]

Closes #692

[MOZGIII]

Actually, it seems we don't need to do any checks on the calls:

https://github.com/humanode-network/substrate/blob/master/frame/balances/src/lib.rs#L284-L300

I am pretty sure the currency is supposed to handle that:

https://github.com/humanode-network/substrate/blob/master/frame/balances/src/lib.rs#L1501-L1563
https://github.com/humanode-network/frontier/blob/locked/polkadot-v0.9.38/frame/evm-balances/src/lib.rs#L439-L497

The question is why doesn't it work as expected?

[dmitrylavrenov]

Actually, it seems we don't need to do any checks on the calls:

https://github.com/humanode-network/substrate/blob/master/frame/balances/src/lib.rs#L284-L300

I am pretty sure the currency is supposed to handle that:

https://github.com/humanode-network/substrate/blob/master/frame/balances/src/lib.rs#L1501-L1563 https://github.com/humanode-network/frontier/blob/locked/polkadot-v0.9.38/frame/evm-balances/src/lib.rs#L439-L497

The question is why doesn't it work as expected?

As we don't use the actual transfer, we use default resolve_creating.

[MOZGIII]

Actually, it seems we don't need to do any checks on the calls:
humanode-network/substrate@master/frame/balances/src/lib.rs#L284-L300
I am pretty sure the currency is supposed to handle that:
humanode-network/substrate@master/frame/balances/src/lib.rs#L1501-L1563 humanode-network/frontier@locked/polkadot-v0.9.38/frame/evm-balances/src/lib.rs#L439-L497
The question is why doesn't it work as expected?

As we don't use the actual transfer, we use default resolve_creating.

Ah, got it! This must be the reason it doesn't do those checks. Ok then!

[MOZGIII]

Looks good so far

[dmitrylavrenov]

Looks good so far

Will add some tests later.

[MOZGIII]

But then, if we follow the trail of calls, we invoke the resolve_creating, which calls deposit_creating, which, in turn, does have the check: https://github.com/humanode-network/frontier/blob/07429a3b559c7277fa20024587f67ae809556054/frame/evm-balances/src/lib.rs#L608C36-L608C36

[MOZGIII]

Hold on, we need to figure out exactly what's going on

[MOZGIII]

I think we can merge this for now, and clean up this later once we have switched to fungible traits.