Implement bridges pot currency swap accounts inititialization#716
Merged
dmitrylavrenov merged 40 commits intomasterfrom Aug 15, 2023
Merged
Implement bridges pot currency swap accounts inititialization#716dmitrylavrenov merged 40 commits intomasterfrom
dmitrylavrenov merged 40 commits intomasterfrom
Conversation
dmitrylavrenov
force-pushed
the
pallet-bridges-init-currency-swap
branch
8 times, most recently
from
dcad6ac to
fc81ea2
Compare
dmitrylavrenov
force-pushed
the
pallet-bridges-init-currency-swap
branch
from
fc81ea2 to
bca632c
Compare
MOZGIII
reviewed
Aug 8, 2023
MOZGIII
reviewed
Aug 8, 2023
dmitrylavrenov
force-pushed
the
pallet-bridges-init-currency-swap
branch
from
07a30b2 to
a71541e
Compare
dmitrylavrenov
force-pushed
the
pallet-bridges-init-currency-swap
branch
from
df49627 to
6a09b50
Compare
MOZGIII
reviewed
Aug 8, 2023
crates/pallet-bridges-initializer-currency-swap/src/upgrade_init.rs
Outdated
Show resolved
Hide resolved
dmitrylavrenov
force-pushed
the
pallet-bridges-init-currency-swap
branch
from
44a6f22 to
35c4ef1
Compare
dmitrylavrenov
force-pushed
the
pallet-bridges-init-currency-swap
branch
from
35c4ef1 to
5ef7ed1
Compare
MOZGIII
reviewed
Aug 15, 2023
MOZGIII
reviewed
Aug 15, 2023
crates/pallet-balanced-currency-swap-bridges-initializer/src/mock/mod.rs
Outdated
Show resolved
Hide resolved
MOZGIII
reviewed
Aug 15, 2023
MOZGIII
reviewed
Aug 15, 2023
MOZGIII
approved these changes
Aug 15, 2023
Contributor
MOZGIII
left a comment
MOZGIII
left a comment
There was a problem hiding this comment.
Great! Last minute finding: now the only thing lacking is proper test descriptions - for what each test aims to verify. Let's add that and we can merge!
Contributor
Author
Sure, check please - ea09ee7. |
dmitrylavrenov
force-pushed
the
pallet-bridges-init-currency-swap
branch
from
ea09ee7 to
53dde76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.