Skip to content

Add eHMND ERC20 precompile#746

Merged
MOZGIII merged 71 commits intomasterfrom
precompile-balances-erc20
Sep 18, 2023
Merged

Add eHMND ERC20 precompile#746
MOZGIII merged 71 commits intomasterfrom
precompile-balances-erc20

Conversation

@dmitrylavrenov
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov commented Aug 24, 2023

Closes #696

@dmitrylavrenov dmitrylavrenov force-pushed the precompile-balances-erc20 branch from 64ef5e9 to 440d8d0 Compare August 24, 2023 20:32
@dmitrylavrenov dmitrylavrenov marked this pull request as ready for review August 25, 2023 12:29
@dmitrylavrenov dmitrylavrenov requested a review from MOZGIII August 25, 2023 12:29
MOZGIII
MOZGIII reviewed Aug 25, 2023
View reviewed changes
MOZGIII
MOZGIII reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an E2E test now that it is easy!

MOZGIII
MOZGIII reviewed Sep 14, 2023
View reviewed changes
MOZGIII
MOZGIII reviewed Sep 14, 2023
View reviewed changes
@MOZGIII MOZGIII changed the title Add ERC20/ERC777 wrapper precompile Add native token ERC20 precompile Sep 14, 2023
@MOZGIII MOZGIII changed the title Add native token ERC20 precompile Add eHMND ERC20 precompile Sep 14, 2023
MOZGIII
MOZGIII reviewed Sep 14, 2023
View reviewed changes
@dmitrylavrenov dmitrylavrenov mentioned this pull request Sep 14, 2023
Open
@dmitrylavrenov
Copy link
Contributor Author

dmitrylavrenov commented Sep 14, 2023

Can we also add E2E tests for this? Could be in another PR...

Will add in separate PR. The issue has been created - #775.

@dmitrylavrenov dmitrylavrenov mentioned this pull request Sep 14, 2023
Open
@dmitrylavrenov
Copy link
Contributor Author

dmitrylavrenov commented Sep 14, 2023

Can we also take https://eips.ethereum.org/EIPS/eip-6093 into consideration? Also, could be in another PR.

Let's add in separate PR to simplify current PR. The issue has been created - #776.

@dmitrylavrenov dmitrylavrenov force-pushed the precompile-balances-erc20 branch from 78e8bf8 to e600842 Compare September 18, 2023 08:24
MOZGIII
MOZGIII reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far! I'll take some more time for the final review today

@dmitrylavrenov dmitrylavrenov force-pushed the precompile-balances-erc20 branch from 6fec460 to a7944d6 Compare September 18, 2023 12:16
@dmitrylavrenov dmitrylavrenov added this pull request to the merge queue Sep 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2023
@MOZGIII MOZGIII added this pull request to the merge queue Sep 18, 2023
Merged via the queue into master with commit c58d5a3 Sep 18, 2023
@MOZGIII MOZGIII deleted the precompile-balances-erc20 branch September 18, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MOZGIII MOZGIII MOZGIII approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ERC20 wrapper precompile

2 participants

@dmitrylavrenov @MOZGIII