Skip to content

Set EVM currency existential deposit to 1#780

Merged
MOZGIII merged 2 commits intomasterfrom
evm-ed
Sep 22, 2023
Merged

Set EVM currency existential deposit to 1#780
MOZGIII merged 2 commits intomasterfrom
evm-ed

Conversation

@MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Sep 18, 2023

Closes #781.

Waits for #785 to land before merging.

@dmitrylavrenov
Copy link
Contributor

Should we research and properly run migrations at this PR?

@MOZGIII
Copy link
Contributor Author

MOZGIII commented Sep 18, 2023

Should we research and properly run migrations at this PR?

Let's discuss

@dmitrylavrenov
Copy link
Contributor

Spent time on research in a little:

  • Balances and EvmBalances don't have some migration logic. Anyway, in case new ED is less than an older one then it doesn't influence on accounts creation/deletion during runtime upgrade
  • Checked that we should update bridges initializer version - 53f319e

@MOZGIII
Copy link
Contributor Author

MOZGIII commented Sep 22, 2023

So, this should just work, right? I don't see why not... However, we'll have to test extensively through try-runtime and on the internal testing stages before we ship even to testnet.

@dmitrylavrenov
Copy link
Contributor

So, this should just work, right? I don't see why not... However, we'll have to test extensively through try-runtime and on the internal testing stages before we ship even to testnet.

Yes, this should. Right, agree with the way of testing.

@MOZGIII MOZGIII added this pull request to the merge queue Sep 22, 2023
Merged via the queue into master with commit 0e0dab1 Sep 22, 2023
@MOZGIII MOZGIII deleted the evm-ed branch September 22, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Set EVM currency existenial deposit to 1

2 participants