Conversation
dmitrylavrenov
approved these changes
Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way we handle the bioauth key when engaging the bioauth flow to be more user-firendly.
It also adds a subcommand to enumerate all the Aura keys in the keystore (which are effectively the bioauth keys).
What this PR doesn't do is it doesn't make the key selectable. The reason for this is it seems the
panics that we use to get previously was triggered by the absence of the key, rather than having more than one key. We now handle no keys properly, but the panic still remains in the case of more than one auth key. So, instead of allowing the user to pick a key when there's more than one, we still trigger a panic.Closes #63