Merged
Conversation
|
you haven't touched |
vkomodey
suggested changes
Aug 19, 2021
vkomodey
suggested changes
Aug 20, 2021
cvat-ui/src/utils/web3wallets.ts
Outdated
| package: MewConnect, | ||
| options: { | ||
| infuraId: '2b78e14debb2482c8865cc1b494bc2dc', // my infura id | ||
| infuraId: '2b78e14debb2482c8865cc1b494bc2dc', |
There was a problem hiding this comment.
Could you do that using env variables from the config?
cvat-ui/src/utils/web3wallets.ts
Outdated
| network: 'mainnet', // optional | ||
| cacheProvider: false, // optional | ||
| providerOptions, // required | ||
| network: 'mainnet', |
There was a problem hiding this comment.
You're using mainnet but provider options for rinkeby. Please, do everything in rinkeby
cvat/settings/base.py
Outdated
|
|
||
| NOTIFY_JOBFLOW_URL = os.getenv('NOTIFY_JOBFLOW_URL', 'http://human-cvat:5001/notify') No newline at end of file | ||
| CVAT_URL = os.getenv('CVAT_URL', 'http://cvat:8080') | ||
| JOBFLOW_URL = os.getenv('JOBFLOW_URL', 'http://human-cvat:5001') No newline at end of file |
cvat/apps/engine/notify_jobflow.py
Outdated
| "payouts": payouts | ||
| } | ||
| requests.post(NOTIFY_JOBFLOW_URL, json=payload) | ||
| requests.post(f'{JOBFLOW_URL}/notify', json=payload) |
There was a problem hiding this comment.
please, check response status code and response message
in case of job flow error your application won't say anything
…ling to notify exchange
vkomodey
suggested changes
Aug 23, 2021
…n orders to get the right network
Dzeranov
pushed a commit
that referenced
this pull request
Jan 8, 2023
Co-authored-by: Dmitry Kalinin <dmitry.kalinin@intel.com> Co-authored-by: Nikita Manovich <nikita.manovich@gmail.com> Co-authored-by: Boris Sekachev <b.sekachev@yandex.ru>
Dzeranov
pushed a commit
that referenced
this pull request
Jan 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.