add support for SUBDOMAIN_INSTALL and PATH_CURRENT_SITE options#60
Closed
mrgum wants to merge 7 commits intohunner:mainfrom
Closed
add support for SUBDOMAIN_INSTALL and PATH_CURRENT_SITE options#60mrgum wants to merge 7 commits intohunner:mainfrom
mrgum wants to merge 7 commits intohunner:mainfrom
Conversation
Author
|
I've not added any tests, I'll have a look and see if I can. |
|
Is this going to get pulled in? I think this is a critical feature for wordpress multisite support. |
removing the tar file would now re download extract and chmod the exec extract needs better logic Revert "when we are upgrading index.php will already exist so using it as a create is pony" This reverts commit d9870d6.
This reverts commit 463b005. this was just as bad still removing the tar downloads it, then removes index.php which then sets the exec to untar it off we need knowledge of the running version of php maybe use wp cli program or run a curl xmlrpc call which is least yuck
This will allow members of the group $wp_group to write to the wordpress directory, enabling them to run wp-cli etc without sudo. There shouldn't be any risk here; by default, $wp_group is '0', i.e. root
Change default mode of wordpress files to 0664
|
Is there any chance of this being reviewed? Looking at the CI failures, it appears related to the Ruby build rather than the PR code (I could be wrong). |
Author
|
life goes on, 8 years later if it isn;t pulled time to stop holding my breathe :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wp-config.php when used for multisite has SUBDOMAIN_INSTALL and PATH_CURRENT_SITE which I need so I've added support for them with $wp_path_current_site and $wp_subdomain_install.