This repository was archived by the owner on Oct 22, 2020. It is now read-only.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
CB\Browser.getFieldsForObjectsets theskipSecurityparameter to true before running the search query to skip security checks when loading objects for field. Since it sets it unconditionally, it would override whatever value the user has set in the field config.I've added a condition to not set the parameter to true if the parameter is already explicitly set in the config. That way the
skipSecurityparameter can be turned off (either in the field config or custom source) to load only objects the user has permission to access.This addresses Task #666, where we need an objects search field to allow users to only select objects they have access to.