(docker) fix platform on manylinux wheel#2
Merged
zhangstevenunity merged 4 commits intohw-native-sys:mainfrom Jan 31, 2026
Merged
(docker) fix platform on manylinux wheel#2zhangstevenunity merged 4 commits intohw-native-sys:mainfrom
zhangstevenunity merged 4 commits intohw-native-sys:mainfrom
Conversation
Explicitly passes the `--plat manylinux_2_34_x86_64` parameter in `auditwheel repair` to make sure the output wheel has the correct tag `ptoas-0.1.0-py3-none-manylinux_2_34_x86_64.whl`.
docker/Dockerfile
Outdated
| # fix missing so | ||
| RUN export LD_LIBRARY_PATH=$LLVM_BUILD_DIR/lib:$PTO_INSTALL_DIR/lib:$LD_LIBRARY_PATH \ | ||
| && auditwheel repair dist/ptoas*.whl | ||
| && auditwheel repair --plat manylinux_2_34_x86_64 dist/ptoas*.whl |
Contributor
There was a problem hiding this comment.
This dockerfile also works for aarch64, need a top level ARG for the arch suffix
Contributor
Author
There was a problem hiding this comment.
The Dockerfile starts from FROM quay.io/pypa/manylinux_2_34_x86_64, I guess we need to parameterize the FROM statement as well.
Contributor
Author
There was a problem hiding this comment.
docker/Dockerfile
Outdated
Contributor
There was a problem hiding this comment.
Here should be RUN git clone https://github.com/zhangstevenunity/PTOAS.git
Contributor
Author
There was a problem hiding this comment.
|
|
||
| ENV PY_PATH="/opt/python/${PY_VER}" | ||
| ENV PATH="${PY_PATH}/bin:${PATH}" | ||
| ENV ARCH=${ARCH} |
Contributor
There was a problem hiding this comment.
This is empty, you need ARG ARCH for args defined before FROM
Zhendong404
pushed a commit
to Zhendong404/PTOAS
that referenced
this pull request
Mar 27, 2026
docs: add math definitions, fix ISA conflicts, and add changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly passes the
--plat manylinux_2_34_x86_64parameter inauditwheel repairto make sure the output wheel has the correct tagptoas-0.1.0-py3-none-manylinux_2_34_x86_64.whl.Generated wheel is already released on pypi: https://pypi.org/project/ptoas/#files