Refactor: rename CallConfig to ChipCallConfig#515
Merged
ChaoWao merged 1 commit intohw-native-sys:mainfrom Apr 10, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the CallConfig class to ChipCallConfig across the entire codebase, including C++ source files, Python bindings, documentation, and unit tests. The feedback identifies an issue in the documentation where ChipCallConfig is instantiated with keyword arguments, which is not supported by the current C++ nanobind implementation, and provides a corrected code snippet to instantiate the object and set attributes separately.
ChaoWao
force-pushed
the
fix/rename-callconfig-to-chipcallconfig
branch
from
379c0b1 to
ab8df92
Compare
The struct holds chip-specific fields (block_dim, aicpu_thread_num, enable_profiling) and lives alongside ChipWorker/ChipCallable/ ChipStorageTaskArgs. Rename to ChipCallConfig for consistency and to free the generic CallConfig name for future use. - Rename CallConfig → ChipCallConfig across C++, bindings, Python, tests - Simplify getting-started.md to use worker.run() kwargs API - Document level-prefixed naming convention in architecture.md so future types (DistCallConfig, etc.) follow the same pattern
ChaoWao
force-pushed
the
fix/rename-callconfig-to-chipcallconfig
branch
from
ab8df92 to
e4930f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
struct CallConfigtoChipCallConfigacross C++, Python bindings, Python API, tests, and docsblock_dim,aicpu_thread_num,enable_profiling) and is used exclusively withChipWorker, so the name should follow theChip*naming convention (ChipWorker,ChipCallable,ChipStorageTaskArgs)getting-started.mdexample to useworker.run()kwargs instead of constructing a config object directlyarchitecture.md— when new level-specific types are added (e.g.DistCallConfig), they should follow the sameChip*/Dist*/ factory pattern asWorkerTesting