[2.x] Migrate actions/upload-artifact from 3 to 4

[dependabot]

Bumps actions/upload-artifact from 3 to 4.

Release notes

Sourced from actions/upload-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

ℹ️ However, this is a major update that includes breaking changes. Artifacts created with versions v3 and below are not compatible with the v4 actions. Uploads and downloads must use the same major actions versions. There are also key differences from previous versions that may require updates to your workflows.

For more information, please see:

1. The changelog post.
2. The README.
3. The migration documentation.
4. As well as the underlying npm package, @​actions/artifact documentation.

New Contributors

• @​vmjoseph made their first contribution in actions/upload-artifact#464

Full Changelog: actions/upload-artifact@v3...v4.0.0

v3.1.3

What's Changed

• chore(github): remove trailing whitespaces by @​ljmf00 in actions/upload-artifact#313
• Bump @​actions/artifact version to v1.1.2 by @​bethanyj28 in actions/upload-artifact#436

Full Changelog: actions/upload-artifact@v3...v3.1.3

v3.1.2

• Update all @actions/* NPM packages to their latest versions- #374
• Update all dev dependencies to their most recent versions - #375

v3.1.1

• Update actions/core package to latest version to remove set-output deprecation warning #351

v3.1.0

What's Changed

• Bump @​actions/artifact to v1.1.0 (actions/upload-artifact#327)
  • Adds checksum headers on artifact upload (actions/toolkit#1095) (actions/toolkit#1063)

Commits

• 6546280 updating package version
• c004fb4 Merge branch 'main' into eggyhead/use-artifact-v2.1.6
• 90aba49 updating toolkit artifact dependency to 2.1.6
• b06cde3 Merge pull request #563 from actions/eggyhead/release-4.3.2
• 1746f4a Revert "updating to release 4.3.2"
• 31685d0 updating to release 4.3.2
• 18bf333 Merge pull request #562 from actions/eggyhead/update-artifact-v215
• dac413b update package lock version
• bb3b4a3 updating package version
• 3e3da83 updating artifact and core dependencies
• Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[emmadesilva]

Breaking Changes documented in https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

Uploading to the same named Artifact multiple times.

Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

This causes an issue in our tests where we run the action multiple times. This probably won't be an issue for real usages unless users want to deploy multiple sites from the same job, which I guess could happen? Best way to resolve it might then be to so support an input for custom artifact names.

[emmadesilva]

Okay, this could be a breaking change, so we are shelving this for next time we make a major release. I don't think it's worth to make one now as of yet just for this change. The v3 action is deprecated, but will be supported until November 30, 2024. So we have plenty of time. (2025 edit: Famous last words)

https://github.com/actions/upload-artifact
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

[DannyvdSluijs]

Okay, this could be a breaking change, so we are shelving this for next time we make a major release. I don't think it's worth to make one now as of yet just for this change. The v3 action is deprecated, but will be supported until November 30, 2024. So we have plenty of time.

https://github.com/actions/upload-artifact https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

@caendesilva I guess time did get up on this in the end. I was just adding this action to my freshly migrated HydePHP site which was a breeze 👍🏼 but now I can't deploy. Is there anything I or others can do to help out?

[emmadesilva]

Okay, this could be a breaking change, so we are shelving this for next time we make a major release. I don't think it's worth to make one now as of yet just for this change. The v3 action is deprecated, but will be supported until November 30, 2024. So we have plenty of time.
https://github.com/actions/upload-artifact https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

@caendesilva I guess time did get up on this in the end. I was just adding this action to my freshly migrated HydePHP site which was a breeze 👍🏼 but now I can't deploy. Is there anything I or others can do to help out?

@DannyvdSluijs Well I completely dropped the ball on this 🙈 I'm getting on this right now! I'm just gonna set up a new major version of this repo and maybe I can ping you when it's ready to beta test?

[emmadesilva]

@dependabot rebase

[emmadesilva]

@dependabot rebase

[dependabot]

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

[emmadesilva]

@dependabot recreate

[emmadesilva]

I'm going to fix failing tests in second PR (reason #35 (comment)), but merging this now, and tagging a beta release. @DannyvdSluijs Would you mind trying out the beta release and letting me know if there are any issues? https://github.com/hydephp/action/releases/tag/v2.0.0-beta

[DannyvdSluijs]

Just leaving the office. But I should be able to check later today or in the upcoming days.

[DannyvdSluijs]

Seems all good: https://github.com/DannyvdSluijs/DannyvdSluijs.github.io/actions/runs/13332449102/job/37244172345

[emmadesilva]

@DannyvdSluijs Fantastic! Thanks for checking! Gonna fix up the tests and make the real release!