Skip to content

Conversation

@emmadesilva
Copy link
Member

Fixes #31

@emmadesilva emmadesilva linked an issue Nov 26, 2024 that may be closed by this pull request
@emmadesilva
Copy link
Member Author

Realized this runs into issues if it's set in config, then we warn even if there is one set.

@emmadesilva
Copy link
Member Author

Manually confirmed that:

  1. No env var and default config adds warning
  2. No env var and no config file existing adds warning
  3. No env var but set config adds no warning
  4. No env var and no config option at all adds no warning (the user removed the option entirely, so they may be using a yaml config) (we could add a case for this but the script is so heavy already)
  5. Any url is set in yaml config adds no warning
  6. Any url is set in namespaced yaml config adds no warning

@emmadesilva emmadesilva merged commit dac3e6d into master Nov 26, 2024
7 checks passed
@emmadesilva emmadesilva deleted the add-warning-if-a-site-url-is-not-set branch November 26, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add warning if a site URL is not set

2 participants