Skip to content

Conversation

@emmadesilva
Copy link
Member

This fixes a bug where the sidebar header brand is not clickable when setting the documentation page output path to ''.

@codecov
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #1427 (5b804b4) into master (00fb664) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master     #1427   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1707      1707           
===========================================
  Files            180       180           
  Lines           4633      4633           
===========================================
  Hits            4633      4633           
Files Coverage Δ
packages/framework/src/Pages/DocumentationPage.php 100.00% <100.00%> (ø)

This fixes a bug where the sidebar header brand is not clickable when setting the documentation page output path to `''`.
@emmadesilva emmadesilva force-pushed the unslash-documentation-page-home-route-name branch from 73d585d to 5b804b4 Compare November 6, 2023 11:44
@emmadesilva emmadesilva marked this pull request as ready for review November 6, 2023 11:45
@emmadesilva emmadesilva merged commit 5c45a46 into master Nov 6, 2023
@emmadesilva emmadesilva deleted the unslash-documentation-page-home-route-name branch November 6, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant