Skip to content

Change internal realtime compiler console context handling #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emmadesilva merged 2 commits into from
Nov 14, 2023
Merged

Change internal realtime compiler console context handling #1462

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae8835f
Change internal console context handling
emmadesilva Nov 14, 2023
80d9171
Merge branch 'master' into change-internal-console-context-string-han…
emmadesilva Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/realtime-compiler/src/ConsoleOutput.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public function getFormatter(): Closure
/** @experimental */
public function printMessage(string $message, string $context): void
{
$this->output->writeln(sprintf('%s [%s]', $message, $context));
$this->output->writeln(sprintf('%s ::context=[%s]', $message, $context));
}

protected function handleOutput(string $buffer): void
Expand Down Expand Up @@ -92,8 +92,8 @@ protected function formatLineForOutput(string $line): ?string
if (str_ends_with(trim($line), 'Accepted') || str_ends_with(trim($line), 'Closing')) {
return $this->verbose ? $this->formatRequestStatusLine($line) : null;
}
if (str_contains($line, '[dashboard@')) {
return $this->formatDashboardContextLine($line);
if (str_contains($line, '::context=')) {
return $this->formatContextLine($line);
}

return $this->formatLine($line, Carbon::now());
Expand Down Expand Up @@ -126,10 +126,10 @@ protected function formatRequestStatusLine(string $line): string
return $this->formatLine(sprintf('%s %s', $address, $status), $this->parseDate($line));
}

protected function formatDashboardContextLine(string $line): string
protected function formatContextLine(string $line): string
{
$message = trim(Str::before($line, '[dashboard@'));
$context = trim(trim(Str::after($line, $message)), '[]');
$message = trim(Str::before($line, '::context='), '[]');
$context = Str::between($line, '::context=[', ']');
$success = str_contains($message, 'Created') || str_contains($message, 'Updated');

return $this->formatLine($message, Carbon::now(), $success ? 'green-500' : 'blue-500', $context);
Expand Down