Update live edit feature to protect against overwriting modified content #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts commit a407d2a
Updates the live edit feature to protect against overwriting content modified in other tabs/editors
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1466 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1728 3456 +1728
=============================================
Files 180 360 +180
Lines 4693 9386 +4693
=============================================
+ Hits 4693 9386 +4693 ☔ View full report in Codecov by Sentry. |
Hashing the file takes over 0.100ms (due to having to load the file again), which arguably is not much, but considering that hashing the content already stored in memory is less than 0.007ms which is an order of magnitude faster, for something that does not affect the feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the live edit feature to protect against overwriting content modified in other tabs/editors. This works by restoring the JavaScript form handler together with a hidden input for the source file hash as it is on the page load. The backend returns a 409 response when the supplied content hash does not match the current one. The frontend then catches the 409 response, prints a JavaScript alert to ask the user if they want to overwrite the page, if they select yes, then the request is send again with a force parameter.