[2.x] Refactor media asset transferring to be in a build task #1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmadesilva
force-pushed
the
refactor-media-asset-transferring-to-a-build-task
branch
from
4c7cd3a to
cfb9148
Compare
For some reason the start message is stripped by the progress bar otherwise
Just for style
Let's us skip it in tests
This reverts commit fc4146d.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x-dev #1536 +/- ##
==========================================
Coverage 99.95% 99.95%
- Complexity 1744 1746 +2
==========================================
Files 180 181 +1
Lines 4723 4725 +2
==========================================
+ Hits 4721 4723 +2
Misses 2 2 ☔ View full report in Codecov by Sentry. |
emmadesilva
changed the title
emmadesilva
deleted the
refactor-media-asset-transferring-to-a-build-task
branch
emmadesilva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual regression check
Changes have been visually tested to ensure console output state is not changed.
Click to show
Before change
After change
Diff