Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Feb 8, 2024

Part of #1538 and allows for deferring the route link evaluation instead of forcing it at construction time. This has the side effect that the destination method now may return a route object instead of string. This targets v2.

@emmadesilva emmadesilva added the WTD Calls What The Diff label Feb 8, 2024
@emmadesilva emmadesilva added this to the v2 milestone Feb 8, 2024
@what-the-diff
Copy link

what-the-diff bot commented Feb 8, 2024

PR Summary

  • Improved URL Retrieval Process
    We've added a new method into the NavItem class for retrieving the link URL. This was previously embedded in the NavItem::getDestination() logic and is now independently handled by NavItem::getLink(), leading to improved code readability and organization.

  • Enhanced Routing in NavItem
    The NavItem::getDestination() method has been modified to return the Route instance if it is the destination type. This provides more flexibility when managing routes.

@emmadesilva emmadesilva marked this pull request as ready for review February 8, 2024 18:31
@emmadesilva emmadesilva merged commit dfc5a58 into refactor-navigation-internals Feb 8, 2024
@emmadesilva emmadesilva deleted the update-navitem-class-to-support-deferring-route-resolves branch February 8, 2024 18:32
emmadesilva added a commit that referenced this pull request Feb 8, 2024
…-deferring-route-resolves

Update NavItem class to support deferring route resolves
@emmadesilva emmadesilva restored the update-navitem-class-to-support-deferring-route-resolves branch February 13, 2024 20:01
@emmadesilva emmadesilva deleted the update-navitem-class-to-support-deferring-route-resolves branch February 13, 2024 20:01
emmadesilva added a commit that referenced this pull request Feb 13, 2024
…-deferring-route-resolves

Update NavItem class to support deferring route resolves
@emmadesilva emmadesilva changed the title Update NavItem class to support deferring route resolves [2.x] Update NavItem class to support deferring route resolves Mar 22, 2024
@emmadesilva emmadesilva removed the WTD Calls What The Diff label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant