Skip to content

Conversation

@emmadesilva
Copy link
Member

This targets HydePHP v2.x via #1568

I realized something, do we actually want to remove duplicate items? What's really the point of that? If two pages have the same label the user might be doing something wrong, so should we try to obscure that by hiding one of them? Better to have visibility so the user can find the issue and manually hide the page they don't want,

Originally posted by @caendesilva in #1568 (comment)

@emmadesilva emmadesilva force-pushed the remove-duplicate-navigation-item-filtering branch from cb543b5 to c8a145b Compare February 19, 2024 13:01
@codecov
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f149a4) 100.00% compared to head (bd90f93) 100.00%.

❗ Current head bd90f93 differs from pull request most recent head a3cd453. Consider uploading reports for the commit a3cd453 to get more accurate results

Additional details and impacted files
@@                        Coverage Diff                        @@
##             improved-navigation-internals     #1573   +/-   ##
=================================================================
  Coverage                           100.00%   100.00%           
+ Complexity                            1763      1761    -2     
=================================================================
  Files                                  184       184           
  Lines                                 4777      4767   -10     
=================================================================
- Hits                                  4777      4767   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva marked this pull request as ready for review February 19, 2024 13:06
@emmadesilva emmadesilva merged commit ff61139 into improved-navigation-internals Feb 19, 2024
@emmadesilva emmadesilva deleted the remove-duplicate-navigation-item-filtering branch February 19, 2024 13:11
@emmadesilva emmadesilva added this to the v2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants