[2.x] Replace navigation item group normalization juggling with looser comparison #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Realizing the part of the problem I'm facing is that the generator doesn't now about all the context when assembling dropdowns. Maybe we need an accessor instead (or add a second factory pass) |
emmadesilva
deleted the
replace-normalization-juggling-with-looser-comparison-
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This targets v2.x via #1568
The reason we slugified the label is to have a looser comparison, considering "Foo" and "foo" the same for navigation groups. But messing with the title then makes it harder to format it back. By instead slugifying at comparison time, we bypass this problem. It also has the "side effect" of having more cases where the title is accurate, hence why some tests needed updating.
This is obviously susceptible to race conditions, but there is only so much we can do if the user is not consistent with their group naming. It also kinda makes the internal state "ugly" but since it reduces complexity and improves accuracy I think it's worth it.