[2.x] Refactor sidebar data handling #1587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1587 +/- ##
================================================================
Coverage 99.95% 99.95%
- Complexity 1767 1774 +7
================================================================
Files 183 183
Lines 4780 4796 +16
================================================================
+ Hits 4778 4794 +16
Misses 2 2 ☔ View full report in Codecov by Sentry. |
emmadesilva
force-pushed
the
refactor-sidebar-data-handling
branch
from
6e84593 to
b3aad5a
Compare
Uses strict typing, though it could also return a bool cast to make 'false' and '' be false, but I prefer strict typing and want to nudge people to use false if they explicably want the sidebar footer to be disabled.
emmadesilva
force-pushed
the
refactor-sidebar-data-handling
branch
from
df9fc51 to
e5a8ad7
Compare
emmadesilva
added a commit
that referenced
this pull request
Feb 25, 2024
emmadesilva
added a commit
that referenced
this pull request
Feb 25, 2024
Uses the link from the view, in order to simplify the API. A drawback of this is that it no longer resolves dynamic links, but given the increased visibility of the option I think the tradeoff is worth it as it makes it easier to customize.
emmadesilva
force-pushed
the
refactor-sidebar-data-handling
branch
2 times, most recently
from
b9f8e3d to
08981bd
Compare
…er-text-handling [2.x] Massively simplify sidebar footer text handling
emmadesilva
force-pushed
the
refactor-sidebar-data-handling
branch
from
865cff5 to
ca62c8c
Compare
emmadesilva
force-pushed
the
refactor-sidebar-data-handling
branch
from
d002f23 to
8d28069
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the sidebar to be more deterministic, and adds related refactors and improvements to the new Navigation API.