Configuration loader improvements #1691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmadesilva
force-pushed
the
configuration-loader-sidebar-header-config
branch
from
1309982 to
301a9bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1691 +/- ##
=========================================
Coverage 99.97% 99.97%
- Complexity 1744 1747 +3
=========================================
Files 181 181
Lines 4661 4669 +8
=========================================
+ Hits 4660 4668 +8
Misses 1 1 ☔ View full report in Codecov by Sentry. |
emmadesilva
force-pushed
the
configuration-loader-sidebar-header-config
branch
from
bdd4304 to
7942491
Compare
Member
Author
emmadesilva
added a commit
that referenced
this pull request
Jun 30, 2024
Merges branch 'configuration-loader-sidebar-header-config' from #1691 into improve-yaml-configuration-loading
emmadesilva
added a commit
that referenced
this pull request
Jun 30, 2024
Squashed commit of the following: commit 2b9d8d1 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 15:35:17 2024 +0200 Refactor internal config handling to use a property commit 5af1fea Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 13:18:21 2024 +0200 Introduce local variable commit f12314a Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 13:11:21 2024 +0200 Configure site name environment variable from Yaml config commit 7942491 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 13:04:06 2024 +0200 Draft new method to merge environment variables commit d32d688 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 13:00:14 2024 +0200 Introduce property for the loaded data commit 301a9bc Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 12:56:49 2024 +0200 Skip the failing tests commit 65b2a05 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 12:55:55 2024 +0200 Add todo commit ebe9146 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 12:52:00 2024 +0200 Test setting site name merges sidebar header commit 3e02dc5 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 12:45:50 2024 +0200 Create failing test commit 2f18f95 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 12:44:33 2024 +0200 Draft initial tests
emmadesilva
added a commit
that referenced
this pull request
Jun 30, 2024
This reverts commit b695a5d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #1523